[Tooling] Don't fail lint on strings not in base language #25030
+22,723
−2,821
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Generated by 🚫 Danger |
AliSoftware
changed the title
|
Contributor
|
| App Name | WordPress | |
| Configuration | Release-Alpha | |
| Build Number | 29992 | |
| Version | PR #25030 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 878d877 | |
| Installation URL | 10fuk8eer9be8 |
Contributor
|
| App Name | Jetpack | |
| Configuration | Release-Alpha | |
| Build Number | 29992 | |
| Version | PR #25030 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 878d877 | |
| Installation URL | 2t2rjijl48el8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Last beta lane failed on
ios_lint_localizationsbecause a string was removed from the codebase in the code-frozenrelease/*branch in #25022.This caused the linter to complain about this for all locales:
How
fail_on_strings_not_in_base_language: falseparameter toios_lint_translationsdownload_localized_stringslane, to ensure we download the latest translations from GlotPress, especially to get the changes onpostTags.addTag,postTags.searchOrAdd.placeholderandpostTags.selectionEmptythat apparently had a placeholder added in their English copy since initially introduced (which is quite dangerous as it can lead to crashes if not all locales are translated with the new copy in time, which is the main reason for the localization linting to be in place) and were otherwise (rightfully, this time) generating linter errors.Testing instructions
Run
bundle exec fastlane lint_localizationsfrom this branch and validate it does not error anymore about keys missing in the base locale.